Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reflect for type id #12495

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

cBournhonesque
Copy link
Contributor

Objective

Add reflect for std::any::TypeId.

I couldn't add ReflectSerialize/ReflectDeserialize for it, it was giving me an error. I don't really understand why, since it works for std::path::PathBuf.

@MrGVSV MrGVSV added C-Usability A simple quality-of-life change that makes Bevy easier to use A-Reflection Runtime information about types labels Mar 15, 2024
@MrGVSV
Copy link
Member

MrGVSV commented Mar 15, 2024

I couldn't add ReflectSerialize/ReflectDeserialize for it, it was giving me an error. I don't really understand why, since it works for std::path::PathBuf.

I don't think you can serialize TypeId since it's an opaque type. And even if we could, there'd be no way to deserialize it since the value is determined at build time

@james7132 james7132 added this pull request to the merge queue Mar 15, 2024
Merged via the queue into bevyengine:main with commit 24b319f Mar 15, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Reflection Runtime information about types C-Usability A simple quality-of-life change that makes Bevy easier to use
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants