Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflect default in colorspaces in bevy_color #12528

Merged
merged 10 commits into from
Mar 17, 2024
Merged

Reflect default in colorspaces in bevy_color #12528

merged 10 commits into from
Mar 17, 2024

Conversation

pablo-lua
Copy link
Contributor

Objective

  • For some reason, we don't reflect the Default trait in colorspaces

Solution

  • Reflect it.

@pablo-lua pablo-lua added A-Rendering Drawing game state to the screen C-Usability A simple quality-of-life change that makes Bevy easier to use labels Mar 17, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 17, 2024
@james7132 james7132 added this pull request to the merge queue Mar 17, 2024
Merged via the queue into bevyengine:main with commit 7002b24 Mar 17, 2024
29 checks passed
@pablo-lua pablo-lua deleted the reflect_default_color branch March 17, 2024 10:57
@BD103 BD103 added the A-Color Color spaces and color math label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@MrGVSV MrGVSV MrGVSV approved these changes

Assignees
No one assigned
Labels
A-Color Color spaces and color math A-Rendering Drawing game state to the screen C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pablo-lua @james7132 @alice-i-cecile @MrGVSV @BD103