Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to enable/disable shadows to MaterialPlugin #12538

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

NiseVoid
Copy link
Contributor

Objective

  • Not all materials need shadow, but a queue_shadows system is always added to the Render schedule and executed

Solution

  • Make a setting for shadows, it defaults to true

Changelog

  • Added shadows_enabled setting to MaterialPlugin

Migration Guide

  • MaterialPlugin now has a shadows_enabled setting, if you didn't spawn the plugin using ::default() or ..default(), you'll need to set it. shadows_enabled: true is the same behavior as the previous version, and also the default value.

@SolarLiner SolarLiner added C-Enhancement A new feature A-Rendering Drawing game state to the screen C-Breaking-Change A breaking change to Bevy's public API that needs to be noted in a migration guide labels Mar 17, 2024
@robtfm robtfm added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 18, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 18, 2024
Merged via the queue into bevyengine:main with commit ce75dec Mar 18, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Breaking-Change A breaking change to Bevy's public API that needs to be noted in a migration guide C-Enhancement A new feature S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants