Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'components' to 'bundles' where it makes sense semantically #1257

Merged
merged 2 commits into from
Jan 19, 2021
Merged

Change 'components' to 'bundles' where it makes sense semantically #1257

merged 2 commits into from
Jan 19, 2021

Conversation

CleanCut
Copy link
Member

@CleanCut CleanCut commented Jan 18, 2021

Following #863 there is a "bundle" concept that semantically means a specific set of types of components we want to add at one time for some given purpose (my wording).

I searched through the codebase and found the places where "components" was still being used in that context, and changed them to "bundle". This couldn't be done via regex since there are many other places that "components" is used in a different context, so I did this through manual inspection. Hopefully my interpretation was accurate! 😄

Some changes similar to these were made in #976

@@ -26,7 +26,7 @@
//! and it gets more powerful every day!
//!
//! ### This Crate
//! The `bevy` crate is just a container crate that makes it easier to consume Bevy components.
//! The `bevy` crate is just a container crate that makes it easier to consume Bevy subcrates.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one-off change is to avoid confusion between the abstract meaning of "components" and the ECS meaning by being more specific.

Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are simple and should have no actual effect on the compiled code while making these bits of the source nicer to understand :)

@cart
Copy link
Member

cart commented Jan 19, 2021

Yup good calls all around!

@cart cart merged commit a0475e9 into bevyengine:master Jan 19, 2021
rparrett pushed a commit to rparrett/bevy that referenced this pull request Jan 27, 2021
…evyengine#1257)

change 'components' to 'bundles' where it makes sense semantically
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants