Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: rounded border should use camera instead of windows #12601

Merged
merged 1 commit into from
Mar 21, 2024
Merged

UI: rounded border should use camera instead of windows #12601

merged 1 commit into from
Mar 21, 2024

Conversation

mockersf
Copy link
Member

Objective

Solution

@mockersf mockersf added C-Bug An unexpected or incorrect behavior A-UI Graphical user interfaces, styles, layouts, and widgets labels Mar 20, 2024
@mockersf mockersf added this to the 0.14 milestone Mar 20, 2024
@alice-i-cecile
Copy link
Member

@chompaa could I get your review here?

@chompaa
Copy link
Member

chompaa commented Mar 20, 2024

LGTM 👍

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 20, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 20, 2024
Merged via the queue into bevyengine:main with commit 7b842e3 Mar 21, 2024
30 checks passed
@rparrett
Copy link
Contributor

rparrett commented Mar 21, 2024 •
edited
Loading

Tested with a modified render_ui_to_texture using viewport coordinates for border radius / size.

Before Screenshot 2024-03-20 at 5 01 05 PM
After Screenshot 2024-03-20 at 5 01 26 PM

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@rparrett rparrett Awaiting requested review from rparrett

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.
4 participants
@mockersf @alice-i-cecile @chompaa @rparrett