-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animatable
for colors
#12614
Animatable
for colors
#12614
Conversation
Co-Authored-By: Alice Cecile <alice.i.cecile@gmail.com>
Do I need to do anything about these errors? A lot of them seem to be unrelated to this PR |
No, those appear to be the result of the new Rust version that just shipped this morning. I'll make an issue. |
Looks awesome! Can't wait to try it out. |
I think I would prefer the implementation to be in bevy_color. It makes more sense to me for the impl to be on the crate declaring the type, like third party adding types will also impl the trait, they won't pr it in bevy_animation |
The problem with this is that it explodes |
Could |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor suggestions, really nice!
Co-authored-by: Zachary Harrold <zac@harrold.com.au>
Co-Authored-By: Zachary Harrold <zac@harrold.com.au>
@solis-lumine-vorago once you can appease CI I'll merge this in :) Looks like some clippy failures. |
Objective
Solution
Animatable
for all color types implementing arithmetic operations.Animatable
s methods are already clamped.color_animation.rs
example.*Assign
operators for color types that already had the corresponding operators. This is just a 'nice to have' and I am happy to remove this if it's not wanted.Changelog
bevy_animation
now depends onbevy_color
.LinearRgba
,Laba
,Oklaba
andXyza
implementAnimatable
.