Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Reflection implementations on Identifier #13648

Merged
merged 3 commits into from
Jun 3, 2024
Merged

feat: Reflection implementations on Identifier #13648

merged 3 commits into from
Jun 3, 2024

Conversation

Bluefinger
Copy link
Contributor

Objective

Solution

  • Implement the same Reflect impls from Entity onto Identifier as they share same/similar purposes,

Testing

  • No compile errors. Currently Identifier has no serialization impls, so there's no need to test a serialization/deserialization roundtrip to ensure correctness.

Changelog

Added

  • Reflection implementations on Identifier.

@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Reflection Runtime information about types labels Jun 3, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jun 3, 2024
@alice-i-cecile
Copy link
Member

Merging as trivial.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 3, 2024
Merged via the queue into bevyengine:main with commit 36f2542 Jun 3, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events A-Reflection Runtime information about types C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bluefinger @alice-i-cecile