Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async_compute example: don't block in the task #13699

Merged
merged 2 commits into from
Jun 6, 2024
Merged

async_compute example: don't block in the task #13699

merged 2 commits into from
Jun 6, 2024

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Jun 5, 2024

Objective

Solution

  • Don't use blocking sleep in the tasks, so that it won't block the task pool

@mockersf mockersf added C-Examples An addition or correction to our examples A-Tasks Tools for parallel and async work labels Jun 5, 2024
tychedelia
tychedelia approved these changes Jun 5, 2024
View reviewed changes
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 6, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jun 6, 2024
Merged via the queue into bevyengine:main with commit 95edd2e Jun 6, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@IceSentry IceSentry IceSentry approved these changes

@tychedelia tychedelia tychedelia approved these changes

Assignees
No one assigned
Labels
A-Tasks Tools for parallel and async work C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AsyncComputeTaskPool blocking main thread on bevy 0.13+ for Linux
4 participants
@mockersf @alice-i-cecile @IceSentry @tychedelia