Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

13743 app exit hang #13744

Merged
merged 8 commits into from
Jun 8, 2024
Merged

13743 app exit hang #13744

merged 8 commits into from
Jun 8, 2024

Conversation

tychedelia
Copy link
Contributor

Fixes #13743.

@tychedelia tychedelia mentioned this pull request Jun 8, 2024
Closed
@alice-i-cecile alice-i-cecile added this to the 0.14 milestone Jun 8, 2024
Brezak
Brezak suggested changes Jun 8, 2024
View reviewed changes
crates/bevy_winit/src/system.rs Outdated Show resolved Hide resolved
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Windowing Platform-agnostic interface layer to run your app in S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Jun 8, 2024
alice-i-cecile
alice-i-cecile approved these changes Jun 8, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, assuming the suggestion is accepted.

@tychedelia @Brezak
Update crates/bevy_winit/src/system.rs
3aa11b2 
Co-authored-by: Brezak <bezak.adam@proton.me>
@tychedelia tychedelia requested a review from Brezak June 8, 2024 17:01
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Jun 8, 2024
@mockersf mockersf added this pull request to the merge queue Jun 8, 2024
Merged via the queue into bevyengine:main with commit 7b14b8c Jun 8, 2024
28 checks passed
mockersf pushed a commit that referenced this pull request Jun 8, 2024
@tychedelia @Brezak @mockersf
13743 app exit hang (#13744)
78ef32b 
Fixes #13743.

---------

Co-authored-by: Brezak <bezak.adam@proton.me>
mockersf pushed a commit that referenced this pull request Jun 8, 2024
@tychedelia @Brezak @mockersf
13743 app exit hang (#13744)
971723e 
Fixes #13743.

---------

Co-authored-by: Brezak <bezak.adam@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

@Brezak Brezak Brezak approved these changes

Assignees
No one assigned
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.

AppExit doesn't close the app if called on startup
4 participants
@tychedelia @alice-i-cecile @mockersf @Brezak