view.inverse_clip_from_world should be world_from_clip #13756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the other changes in bevyengine#13489
mockersf
approved these changes
Jun 8, 2024
mockersf
added
C-Bug
NthTensor
approved these changes
Jun 9, 2024
NthTensor
added
the
S-Ready-For-Final-Review
mockersf
pushed a commit
that referenced
this pull request
Jun 9, 2024
As per the other changes in #13489 `view.inverse_clip_from_world` should be `world_from_clip`. # Objective fixes #13749 ## Solution Modified lines.wgsl to use the right name as the current name does not exist. ## Testing I ran the 3d_gizmos example and pressed "p".  
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the other changes in #13489
view.inverse_clip_from_worldshould beworld_from_clip.Objective
fixes #13749
Solution
Modified lines.wgsl to use the right name as the current name does not exist.
Testing
I ran the 3d_gizmos example and pressed "p".