Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let init_non_send_resource require FromWorld instead of Default #13779

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Let init_non_send_resource require FromWorld instead of Default #13779

merged 2 commits into from
Jun 10, 2024

Conversation

NiklasEi
Copy link
Member

@NiklasEi NiklasEi commented Jun 9, 2024

Objective

Solution

  • The resource initialized with init_non_send_resource requires FromWorld again

@NiklasEi
Copy link
Member Author

NiklasEi commented Jun 9, 2024

If possible, I would like this to get into 0.14 in order to not break that API unnecessarily.

@NiklasEi NiklasEi added P-Regression Functionality that used to work but no longer does. Add a test for this! A-App Bevy apps and plugins labels Jun 9, 2024
@alice-i-cecile alice-i-cecile added this to the 0.14 milestone Jun 9, 2024
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Jun 9, 2024
@NiklasEi
Copy link
Member Author

NiklasEi commented Jun 9, 2024

I didn't even manage to write on Discord before Alice had labeled and approved :D

mockersf
mockersf approved these changes Jun 9, 2024
View reviewed changes
Copy link
Member

@mockersf mockersf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want to add a test to avoid another future regression?

@mockersf mockersf added this pull request to the merge queue Jun 10, 2024
Merged via the queue into bevyengine:main with commit 69d7da9 Jun 10, 2024
27 checks passed
mockersf pushed a commit that referenced this pull request Jun 10, 2024
@NiklasEi @mockersf
Let init_non_send_resource require FromWorld instead of Default (#13779)
91db570 
# Objective

- Let `init_non_send_resource` take `FromWorld` values again, not only
`Default`
- This reverts an unintended breaking change introduced in #9202

## Solution

- The resource initialized with `init_non_send_resource` requires
`FromWorld` again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkiFire13 SkiFire13 SkiFire13 approved these changes

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-App Bevy apps and plugins C-Bug An unexpected or incorrect behavior P-Regression Functionality that used to work but no longer does. Add a test for this! S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.
4 participants
@NiklasEi @alice-i-cecile @mockersf @SkiFire13