Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl Debug for ExtendedMaterial #14140

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

NWPlayer123
Copy link
Contributor

Objective

Both Material and MaterialExtension (base and extension) can derive Debug, so there's no reason to not allow ExtendedMaterial to derive it

Solution

  • Describe the solution used to achieve the objective above.
    Add Debug to the list of derived traits

Testing

  • Did you test these changes? If so, how?
    I compiled my test project on latest commit, making sure it actually compiles
  • How can other people (reviewers) test your changes? Is there anything specific they need to know?
    Create an ExtendedMaterial instance, try to println!("{:?}", material);

Copy link
Contributor

github-actions bot commented Jul 4, 2024

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Jul 4, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 4, 2024
Merged via the queue into bevyengine:main with commit c6a89c2 Jul 5, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants