-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip batching for phase items from other pipelines #14296
Conversation
Can you turn the original bevy vector shapes issue into a unit-test to use as regression testing please? |
I considered this but it's a pretty non-trivial amount of setup, definitely not much of a unit test, would require a example setting up pipelines with custom phase items and batching. It can still be done but wanted to put up this fix so we can try and get it in for 0.14.1 There's also equivalent if statements in the other batching methods, so there's a question of to what fidelity are we going to test every piece of the rendering logic. |
Yeah, I wouldn't worry about automated testing here for now. We need a more cohesive design to this across rendering. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM when testing it.
# Objective - Fix #14295 ## Solution - Early out when `GFBD::get_index_and_compare_data` returns None. ## Testing - Tested on a selection of examples including `many_foxes` and `3d_shapes`. - Resolved the original issue in `bevy_vector_shapes`.
Objective
Solution
GFBD::get_index_and_compare_data
returns None.Testing
many_foxes
and3d_shapes
.bevy_vector_shapes
.