Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip batching for phase items from other pipelines #14296

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

james-j-obrien
Copy link
Contributor

@james-j-obrien james-j-obrien commented Jul 13, 2024

Objective

Solution

  • Early out when GFBD::get_index_and_compare_data returns None.

Testing

  • Tested on a selection of examples including many_foxes and 3d_shapes.
  • Resolved the original issue in bevy_vector_shapes.

@james-j-obrien james-j-obrien added the A-Rendering Drawing game state to the screen label Jul 13, 2024
@Hexorg
Copy link
Contributor

Hexorg commented Jul 14, 2024

Can you turn the original bevy vector shapes issue into a unit-test to use as regression testing please?

@alice-i-cecile alice-i-cecile added this to the 0.14.1 milestone Jul 14, 2024
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels Jul 14, 2024
@james-j-obrien
Copy link
Contributor Author

james-j-obrien commented Jul 14, 2024

Can you turn the original bevy vector shapes issue into a unit-test to use as regression testing please?

I considered this but it's a pretty non-trivial amount of setup, definitely not much of a unit test, would require a example setting up pipelines with custom phase items and batching.

It can still be done but wanted to put up this fix so we can try and get it in for 0.14.1

There's also equivalent if statements in the other batching methods, so there's a question of to what fidelity are we going to test every piece of the rendering logic.

@alice-i-cecile
Copy link
Member

Yeah, I wouldn't worry about automated testing here for now. We need a more cohesive design to this across rendering.

@alice-i-cecile alice-i-cecile added S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Jul 14, 2024
Copy link
Member

@TrialDragon TrialDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when testing it.

@TrialDragon TrialDragon added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 1, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Aug 2, 2024
Merged via the queue into bevyengine:main with commit b98d15f Aug 2, 2024
29 checks passed
mockersf pushed a commit that referenced this pull request Aug 2, 2024
# Objective

- Fix #14295

## Solution

- Early out when `GFBD::get_index_and_compare_data` returns None.

## Testing

- Tested on a selection of examples including `many_foxes` and
`3d_shapes`.
- Resolved the original issue in `bevy_vector_shapes`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improper batching of non-mesh phase items.
4 participants