Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
d_xz
, like in the original SMAA implementation. This not already being the case was likely a mistake when converting from HLSL to WGSLSolution
d_xz.x
andd_xz.y
instead ofd.x
andd.z
Testing
x86_64-pc-windows-gnu
1.79.0
with the latest NVIDIA drivers. App runs with SMAA enabled and everything seems to work as intended