Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bevy_winit not building with serialize feature #14469

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Fix bevy_winit not building with serialize feature #14469

merged 1 commit into from
Jul 26, 2024

Conversation

BD103
Copy link
Member

@BD103 BD103 commented Jul 25, 2024

Objective

  • bevy_winit fails to build with just the serialize feature.

Solution

  • It was failing because bevy_winit did not pass the serialize flag to two of its dependencies: bevy_input and bevy_window.
  • To fix this, add these crates to the feature flag.

Testing

# On Linux, you must also specify a backend: `x11` or `wayland`.
# You can do this with `-F serialize,x11`, etc.
cargo check -p bevy_winit --no-default-features -F serialize

@BD103 BD103 added C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy A-Windowing Platform-agnostic interface layer to run your app in C-Regression Functionality that used to work but no longer does. Add a test for this! S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 25, 2024
@janhohenheim janhohenheim added this to the 0.14.1 milestone Jul 26, 2024
@mockersf mockersf added this pull request to the merge queue Jul 26, 2024
@janhohenheim janhohenheim added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 26, 2024
Merged via the queue into bevyengine:main with commit e49527e Jul 26, 2024
38 checks passed
@BD103 BD103 deleted the winit-serialize branch July 26, 2024 22:32
mockersf pushed a commit that referenced this pull request Aug 2, 2024
@BD103 @mockersf
Fix bevy_winit not building with serialize feature (#14469)
c4ea477 
# Objective

- `bevy_winit` fails to build with just the `serialize` feature.
- Caught by [`flag-frenzy`](https://github.com/TheBevyFlock/flag-frenzy)
in [this
run](https://github.com/TheBevyFlock/flag-frenzy/actions/runs/10087486444/job/27891723948),
using the new, nuanced configuration system!

## Solution

- It was failing because `bevy_winit` did not pass the `serialize` flag
to two of its dependencies: `bevy_input` and `bevy_window`.
- To fix this, add these crates to the feature flag.

## Testing

```bash
# On Linux, you must also specify a backend: `x11` or `wayland`.
# You can do this with `-F serialize,x11`, etc.
cargo check -p bevy_winit --no-default-features -F serialize
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@janhohenheim janhohenheim janhohenheim approved these changes

Assignees
No one assigned
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Bug An unexpected or incorrect behavior C-Regression Functionality that used to work but no longer does. Add a test for this! D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.14.1
Development

Successfully merging this pull request may close these issues.
3 participants
@BD103 @mockersf @janhohenheim