Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated bevy_dynamic_plugin #14534

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Remove deprecated bevy_dynamic_plugin #14534

merged 2 commits into from
Jul 30, 2024

Conversation

BD103
Copy link
Member

@BD103 BD103 commented Jul 30, 2024

Objective

Solution

  • Remove all dynamic plugin functionality.
  • Update documentation to reflect this change.

Migration Guide

Dynamic plugins were deprecated in 0.14 for being unsound, and they have now been fully removed. Please consider using the alternatives listed in the bevy_dynamic_plugin crate documentation, or worst-case scenario you may copy the code from 0.14.

@BD103 BD103 added D-Trivial Nice and easy! A great choice to get started with Bevy A-App Bevy apps and plugins M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 30, 2024
@BD103 BD103 added this to the 0.15 milestone Jul 30, 2024
alice-i-cecile
alice-i-cecile requested changes Jul 30, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should just delete this crate / folder completely. No need to keep it around collecting dust.

@BD103 BD103 force-pushed the rm-dynamic-plugin branch from e914d96 to d52a7f0 Compare July 30, 2024 15:17
@BD103
Copy link
Member Author

BD103 commented Jul 30, 2024

IMO we should just delete this crate / folder completely. No need to keep it around collecting dust.

Good call, done!

@BD103 BD103 changed the title Remove deprecated dynamic plugins Remove deprecated bevy_dynamic_plugin Jul 30, 2024
alice-i-cecile
alice-i-cecile approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks!

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 30, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 30, 2024
Merged via the queue into bevyengine:main with commit d722fef Jul 30, 2024
31 checks passed
@ItsDoot ItsDoot mentioned this pull request Aug 17, 2024
Closed
@BD103 BD103 deleted the rm-dynamic-plugin branch August 17, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-App Bevy apps and plugins D-Trivial Nice and easy! A great choice to get started with Bevy M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.15
Development

Successfully merging this pull request may close these issues.
2 participants
@BD103 @alice-i-cecile