Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Adds UiRenderGraphConfig analogous to BaseRenderGraphConfig #1500

Closed
wants to merge 3 commits into from

Conversation

mtsr
Copy link
Contributor

@mtsr mtsr commented Feb 22, 2021

Because I added a post processing pass between Main and Swap Chain, I had a need to have UI use another Depth Texture.

This PR adds a UiRenderGraphConfig analogous to BaseRenderGraphConfig.

I haven't yet added all the options or fixed up usages throughout Bevy, because I first wanted to hear back whether this seems like a worthwhile approach.

@Ratysz Ratysz added C-Feature A new feature, making something new possible A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets labels Feb 22, 2021
@rmsc
Copy link
Contributor

rmsc commented Feb 22, 2021

I'm developing a plugin that needs a small change to the base render graph. It turns out deviating from the default BaseRenderGraphConfig in a plugin is really awkward. I either forced the plugin user to do the modifications themselves, or I had to implement my own version of DefaultPlugins from scratch.

I proposed #1382 as a way for a plugin to modify the default configuration. The feedback I got is that BaseRenderGraphConfig and others will likely be dropped in favor of configuration resources, which I tend to favor.

That said, maybe for the short term this is the way to go.

@mtsr mtsr closed this May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets C-Feature A new feature, making something new possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants