-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add allow_all
and deny_all
methods to DynamicSceneBuilder
#15222
Merged
alice-i-cecile
merged 12 commits into
bevyengine:main
from
atornity:scene-builder-allow-deny-all
Sep 15, 2024
Merged
add allow_all
and deny_all
methods to DynamicSceneBuilder
#15222
alice-i-cecile
merged 12 commits into
bevyengine:main
from
atornity:scene-builder-allow-deny-all
Sep 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Usability
A targeted quality-of-life change that makes Bevy easier to use
A-Scenes
Serialized ECS data stored on the disk
S-Needs-Review
Needs reviewer attention (from anyone!) to move forward
labels
Sep 15, 2024
alice-i-cecile
approved these changes
Sep 15, 2024
janhohenheim
approved these changes
Sep 15, 2024
Doesn't this mean that the preexisting |
janhohenheim
added
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
and removed
S-Needs-Review
Needs reviewer attention (from anyone!) to move forward
labels
Sep 15, 2024
Agreed; I'll update the migration guide of the linked PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Scenes
Serialized ECS data stored on the disk
C-Usability
A targeted quality-of-life change that makes Bevy easier to use
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
It would be convenient to be able to quickly deny or allow all components and resources on a
DynamicSceneBuilder
with a single method call.Context: #15210 renamed
{allow/deny}_all
to{allow/deny}_all_components
.Solution
Added two new methods to
DynamicSceneBuilder
,allow_all
anddeny_all
, which affect both the component and resource filters.Showcase
Before
After