-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various picking bugfixes #15293
Merged
Merged
Various picking bugfixes #15293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NthTensor
added
C-Bug
An unexpected or incorrect behavior
A-Input
Player input via keyboard, mouse, gamepad, and more
D-Modest
A "normal" level of difficulty; suitable for simple features or challenging fixes
S-Needs-Testing
Testing must be done before this is safe to merge
A-Picking
Pointing at and selecting objects of all sorts
labels
Sep 19, 2024
alice-i-cecile
added
S-Needs-Review
Needs reviewer attention (from anyone!) to move forward
and removed
S-Needs-Testing
Testing must be done before this is safe to merge
labels
Sep 19, 2024
alice-i-cecile
approved these changes
Sep 19, 2024
This has been tested by @brandon-reinhart, and is at least an improvement on the current behavior. See these messages. |
I'll be using this PR to just collect up a big batch of fixes so we can merge them all at once. |
brandon-reinhart
approved these changes
Sep 20, 2024
NthTensor
added
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
and removed
S-Needs-Review
Needs reviewer attention (from anyone!) to move forward
labels
Sep 20, 2024
@NthTensor say the word and I'll merge this in. |
LGMT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Input
Player input via keyboard, mouse, gamepad, and more
A-Picking
Pointing at and selecting objects of all sorts
C-Bug
An unexpected or incorrect behavior
D-Modest
A "normal" level of difficulty; suitable for simple features or challenging fixes
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
DragEnd
firing when drag finished.DragStart
firing when dragging across pick-able entities.Click
coming afterDrop
and obliterating finished drag interactions.Big thanks to B. Reinhart for testing picking in their codebase and identifying these issues early.
Solution
Up
andClick
events.Down
being determined using theprevious_hover_map
rather thanhover_map
, a regression compared tobevy_mod_picking
. I think this is what was messing up drag events.PointerEnd
would fire multiple times andPointerStart
would fire when dragging onto a new entity.Out
now fired beforeDragLeave
andClick/Up
now fire beforeDragDrop
.Testing
These changes are currently sporadically tested.