Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings triggered by elided_named_lifetimes lint #15328

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Fix warnings triggered by elided_named_lifetimes lint #15328

merged 3 commits into from
Sep 20, 2024
+60 −42

Conversation

VitalyAnkh
Copy link
Contributor

Objective

Eliminate some warnings introduced by the new rust lint elided_named_lifetimes, fix #15326.

Solution

  • Add or remove lifetime markers to not trigger the lint.

Testing

  • When the lint comes to stable, the CI will fail and this PR could fix that.

@VitalyAnkh VitalyAnkh changed the title Fix some compilation warnings Fix warnings triggered by elided_named_lifetimes lint Sep 20, 2024
@VitalyAnkh
Copy link
Contributor Author

Hold off and see whether the lint makes it into the rustc beta version.

@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy C-Code-Quality A section of code that is hard to understand or change labels Sep 20, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 20, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Sep 20, 2024
Merged via the queue into bevyengine:main with commit 661ab1a Sep 20, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Many elided lifetime has a name warnings
3 participants
@VitalyAnkh @james7132 @alice-i-cecile