Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RenderUiSystem::ExtractTextureSlice #15332

Merged
merged 1 commit into from
Sep 21, 2024
Merged

RenderUiSystem::ExtractTextureSlice #15332

merged 1 commit into from
Sep 21, 2024
+3 −1

Conversation

ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Sep 20, 2024 •
edited
Loading

Objective

Fixes #15330

Solution

  1. Add an ExtractTextureSlice variant to RenderUiSystem.
  2. Add RenderUiSystem::ExtractTextureSlice to the ExtractSchedule between ExtractImages and ExtractBorders.
  3. Add extract_ui_texture_slices to the new ExtractTextureSlice system set.

Which results in texture slice nodes being extracted before borders. No more z-fighting, borders will always be drawn on top of texture-sliced images.

@ickshonpe
* Added an ExtractTextureSlice variant to RenderUiSystem.
e670c09 
* Added `RenderUiSystem::ExtractTextureSlice` to the `ExtractSchedule`.

* Added `extract_ui_texture_slices` to the new `ExtractTextureSlice` system set.
@ickshonpe ickshonpe changed the title * Added an ExtractTextureSlice variant to RenderUiSystem. RenderUiSystem::ExtractTextureSlice Sep 20, 2024
@ickshonpe ickshonpe added A-UI Graphical user interfaces, styles, layouts, and widgets A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels Sep 20, 2024
@alice-i-cecile alice-i-cecile added this to the 0.15 milestone Sep 20, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 20, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 20, 2024
Merged via the queue into bevyengine:main with commit 48f2bd4 Sep 21, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@tychedelia tychedelia tychedelia approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.15
Development

Successfully merging this pull request may close these issues.

Border vs TextureSlicer flickering
3 participants
@ickshonpe @alice-i-cecile @tychedelia