-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move ShortName to bevy_reflect #15340
move ShortName to bevy_reflect #15340
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh good, I was worried this would mess up the feature flags for bevy_ecs
. Nice to see this work cleanly.
I think this makes sense there: it's a tool to work with type names.
Can you update your migration guide to be a bit more descriptive? It doesn't actually describe the fix when read outside of the context of this PR. |
Co-authored-by: François Mockers <francois.mockers@vleue.com>
Given that |
I think I see what you mean now. What do you suggest as a solution, keeping in mind we, ideally, don't want a |
I think the only real options are to move it into it's own crate in the bevy repo or move it out like we did with |
Objective
Solution
Testing
Migration Guide
bevy_utils::ShortName
should instead now bebevy_reflect::ShortName
.