-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate meshes and materials to required components #15524
Merged
Merged
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
bf44df8
Migrate meshes to required components
Jondolf 2423a92
Deprecate mesh bundles
Jondolf 92fe7fe
Merge branch 'main' into mesh-required-components-v2
Jondolf 4fa48d8
Remove redundant requires from `Mesh3d`
Jondolf 65702d8
Improve docs and deprecation notices
Jondolf 27bdfb7
Deprecate `MaterialMesh2dBundle`
Jondolf 36720ef
Finish core migration
Jondolf 9bd73bb
Revert glTF asset label rename
Jondolf 7fca426
Fix B0004
Jondolf a5dac69
Fix 2D material extraction
Jondolf b3619e6
Fix 3D material mesh extraction
Jondolf e2bd5c2
Add `PlaceholderMaterial2d`
Jondolf dba5206
Fix material extraction and default materials, improve docs
Jondolf c6db025
Fix docs
Jondolf cc6c5de
Fix some more extraction issues
Jondolf 0e00aa0
`Reflect` on my life choices
Jondolf 95c5d38
Remove `WithMesh2d` from example
Jondolf 0a18f43
Fix some more
Jondolf ff4b64b
Fix even more
Jondolf d9345ab
Merge branch 'main' into mesh-required-components-v2
Jondolf b1e2a96
Revert some material plugin changes and fix wireframes
Jondolf 0aead94
Fix doc tests
Jondolf 4ccf47a
Merge branch 'main' into mesh-required-components-v2
Jondolf 70d5b6a
Fix B0004 error description
Jondolf 8a51e25
Fix more doc stuff (please CI gods)
Jondolf a9ae0a0
Fix outdated docs
Jondolf 3a23df8
Merge branch 'main' into mesh-required-components-v2
Jondolf b121e69
Fix new example
Jondolf 3af1393
Merge branch 'main' into mesh-required-components-v2
Jondolf 8c0a77b
Fix vertex color format
Jondolf 4ca2d55
Move `Mesh2d` to `bevy_render` and fix examples (again)
Jondolf 5367f0b
Improve docs
Jondolf 4e3a0ee
Fix doc test
Jondolf bc791da
Fix unused asset server and mesh imports
Jondolf d5947d5
Use `AssetId::default()`
Jondolf 4c6f9ed
Merge branch 'mesh-required-components-v2' of https://github.com/Jond…
Jondolf 76b57c6
Merge branch 'main' into mesh-required-components-v2
Jondolf f4aa5a7
Fix doc test imports
Jondolf d82e264
Require `HasMaterial2d` in example
Jondolf 40166a4
Merge branch 'main' into mesh-required-components-v2
cart File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to move this to the specific places it was needed in this file but then i stumbled upon #15531, like you probably did q: