Add no_std support to bevy_mikktspace
#15528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rely on `libm` for maths operations not supported in `core`.
bushrat011899
added
C-Feature
alice-i-cecile
added
the
A-Math
BenjaminBrienen
approved these changes
Sep 29, 2024
| @@ -1808,3 +1809,63 @@ unsafe fn GenerateInitialVerticesIndexList<I: Geometry>( | |||
| } | |||
| return iTSpacesOffs; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Good idea to keep the cfg feature hell in one place. This does remind me of the functionality of bevy_math::ops, though.
There was a problem hiding this comment.
Yeah I think it would make sense to move this into bevy_math, but that's a much harder change since it includes (comparatively) lots of dependencies. For now I think this is an acceptable mess, but highlights the need for possible changes.
lewiszlw
approved these changes
Sep 30, 2024
lewiszlw
added
S-Ready-For-Final-Review
robtfm
pushed a commit
to robtfm/bevy
that referenced
this pull request
Oct 4, 2024
# Objective - Contributes to bevyengine#15460 - Allows `bevy_mikktspace` to be used in `no_std` contexts. ## Solution - Added `std` (default) and `libm` features which control the inclusion of the standard library. To use `bevy_mikktspace` in `no_std` environments, enable the `libm` feature. ## Testing - CI - `cargo clippy -p bevy_mikktspace --target "x86_64-unknown-none" --no-default-features --features libm`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
no_stdBevy #15460bevy_mikktspaceto be used inno_stdcontexts.Solution
std(default) andlibmfeatures which control the inclusion of the standard library. To usebevy_mikktspaceinno_stdenvironments, enable thelibmfeature.Testing
cargo clippy -p bevy_mikktspace --target "x86_64-unknown-none" --no-default-features --features libm