[Merged by Bors] - fix flip of contributor bird #1573
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Mar 6, 2021
|
This is more explicit so I think we should roll with it, but maybe we should also just re-disable back-face culling? I don't see much of a reason to cull back facing sprites given that the 3d-perspective never changes (and there is no "overlapping geometry" to be culled). |
Ratysz
approved these changes
Mar 7, 2021
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 7, 2021
Since 8921717, some birds in example `contributors` where not colored. Fix is to use `flip_x` of `Sprite` instead of setting `transform.scale.x` to `-1` as described in #1407. It may be an unintended side effect, as now we can't easily display a colored sprite while changing it's scale from `1` to `-1`, we would have to change it's scale from `1` to `0`, then flip it, then change scale from `0` to `1`.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 8921717, some birds in example
contributorswhere not colored.Fix is to use
flip_xofSpriteinstead of settingtransform.scale.xto-1as described in #1407.It may be an unintended side effect, as now we can't easily display a colored sprite while changing it's scale from
1to-1, we would have to change it's scale from1to0, then flip it, then change scale from0to1.