[Merged by Bors] - Reorder Imports in Examples #1598
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Code-Quality
alice-i-cecile
approved these changes
Mar 8, 2021
alice-i-cecile
added
the
S-Ready-For-Final-Review
mockersf
approved these changes
Mar 8, 2021
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 9, 2021
This only affected 2 Examples: * `generic_reflection`: For some reason, a `pub use` statement was used. This was removed, and alphabetically ordered. * `wireframe`: This example used the `bevy_internal` crate directly. Changed to use `bevy` instead. All other Example Imports are correct. One potential subjective change is the `removel_detection` example. Unlike all other Examples, it has its (first) explanatory comment before the Imports.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only affected 2 Examples:
generic_reflection: For some reason, apub usestatement was used. This was removed, and alphabetically ordered.wireframe: This example used thebevy_internalcrate directly. Changed to usebevyinstead.All other Example Imports are correct.
One potential subjective change is the
removel_detectionexample.Unlike all other Examples, it has its (first) explanatory comment before the Imports.