Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ZIndex docs #16536

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Improve ZIndex docs #16536

merged 2 commits into from
Nov 28, 2024

Conversation

UkoeHB
Copy link
Contributor

@UkoeHB UkoeHB commented Nov 28, 2024

Objective

  • In 0.14, ZIndex and GlobalZIndex where split from a shared enum into separate components. There have been a few people confused by the behavior of ZIndex when they really needed GlobalZIndex.

Solution

  • Update ZIndex docs to improve discoverability of GlobalZIndex.

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-UI Graphical user interfaces, styles, layouts, and widgets D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 28, 2024
BenjaminBrienen
BenjaminBrienen suggested changes Nov 28, 2024
View reviewed changes
crates/bevy_ui/src/ui_node.rs Outdated Show resolved Hide resolved
@UkoeHB @BenjaminBrienen
Update crates/bevy_ui/src/ui_node.rs
a3f9986 
Co-authored-by: Benjamin Brienen <benjamin.brienen@outlook.com>
@kristoff3r kristoff3r added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 28, 2024
@alice-i-cecile alice-i-cecile added this to the 0.15 milestone Nov 28, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 28, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 28, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 28, 2024
Merged via the queue into bevyengine:main with commit 696c006 Nov 28, 2024
29 checks passed
@UkoeHB UkoeHB deleted the zindex branch November 28, 2024 19:06
mockersf pushed a commit that referenced this pull request Nov 28, 2024
@UkoeHB @BenjaminBrienen @mockersf
Improve ZIndex docs (#16536)
02b94d8 
# Objective

- In 0.14, ZIndex and GlobalZIndex where split from a shared enum into
separate components. There have been a few people confused by the
behavior of ZIndex when they really needed GlobalZIndex.

## Solution

- Update ZIndex docs to improve discoverability of GlobalZIndex.

---------

Co-authored-by: Benjamin Brienen <benjamin.brienen@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBrienen BenjaminBrienen BenjaminBrienen approved these changes

@ickshonpe ickshonpe ickshonpe approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@doup doup doup approved these changes

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Docs An addition or correction to our documentation D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.15
Development

Successfully merging this pull request may close these issues.
6 participants
@UkoeHB @doup @alice-i-cecile @ickshonpe @BenjaminBrienen @kristoff3r