[Merged by Bors] - gltf-loader: support data url for images #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-Assets
mockersf
approved these changes
Apr 5, 2021
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 13, 2021
This allows the `glTF-Embedded` variants in the [sample models](https://github.com/KhronosGroup/glTF-Sample-Models/) to be used. The data url format is relatively small, so I didn't include a crate like [docs.rs/data-url](https://docs.rs/data-url/0.1.0/data_url/). Also fixes the 'Box With Spaces' model as URIs are now percent-decoded. cc #1802
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
jihiggins
pushed a commit
to jihiggins/bevy
that referenced
this pull request
Apr 18, 2021
This allows the `glTF-Embedded` variants in the [sample models](https://github.com/KhronosGroup/glTF-Sample-Models/) to be used. The data url format is relatively small, so I didn't include a crate like [docs.rs/data-url](https://docs.rs/data-url/0.1.0/data_url/). Also fixes the 'Box With Spaces' model as URIs are now percent-decoded. cc bevyengine#1802
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
This allows the `glTF-Embedded` variants in the [sample models](https://github.com/KhronosGroup/glTF-Sample-Models/) to be used. The data url format is relatively small, so I didn't include a crate like [docs.rs/data-url](https://docs.rs/data-url/0.1.0/data_url/). Also fixes the 'Box With Spaces' model as URIs are now percent-decoded. cc bevyengine#1802
vabrador
pushed a commit
to vabrador/bevy
that referenced
this pull request
Sep 15, 2021
This allows the `glTF-Embedded` variants in the [sample models](https://github.com/KhronosGroup/glTF-Sample-Models/) to be used. The data url format is relatively small, so I didn't include a crate like [docs.rs/data-url](https://docs.rs/data-url/0.1.0/data_url/). Also fixes the 'Box With Spaces' model as URIs are now percent-decoded. cc bevyengine#1802
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the
glTF-Embeddedvariants in the sample models to be used.The data url format is relatively small, so I didn't include a crate like docs.rs/data-url.
Also fixes the 'Box With Spaces' model as URIs are now percent-decoded.
cc #1802