Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix memory size for PointLightBundle #1940

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - fix memory size for PointLightBundle #1940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c5b205
needed for correct sizing of buffer and alignement of lights > 1
mockersf Apr 16, 2021
0f5815a
add notes on why array for single value
mockersf Apr 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions crates/bevy_pbr/src/light.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ impl Default for PointLight {
pub(crate) struct PointLightUniform {
pub pos: [f32; 4],
pub color: [f32; 4],
pub inverse_range_squared: f32,
// storing as a `[f32; 4]` for memory alignement
pub inverse_range_squared: [f32; 4],
mockersf marked this conversation as resolved.
Show resolved Hide resolved
}

unsafe impl Byteable for PointLightUniform {}
Expand All @@ -43,7 +44,7 @@ impl PointLightUniform {
PointLightUniform {
pos: [x, y, z, 1.0],
color,
inverse_range_squared: 1.0 / (light.range * light.range),
inverse_range_squared: [1.0 / (light.range * light.range), 0., 0., 0.],
}
}
}
Expand Down
1 change: 1 addition & 0 deletions crates/bevy_pbr/src/render_graph/lights_node.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ impl Node for LightsNode {
#[repr(C)]
#[derive(Debug, Clone, Copy)]
struct LightCount {
// storing as a `[u32; 4]` for memory alignement
pub num_lights: [u32; 4],
}

Expand Down