Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix alien_cake_addict: cake should not be at height of player's location #1954

Closed
wants to merge 1 commit into from

Conversation

alilee
Copy link

@alilee alilee commented Apr 18, 2021

Just to avoid confusion to close readers of the example, this fix ensures cake is transformed to the height at the cake's cell, rather than the height at the player's cell.

Without this, cake may be floating or buried, depending on where the player is standing at time of spawning.

Love your work!

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples labels Apr 18, 2021
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 18, 2021
@cart
Copy link
Member

cart commented Apr 19, 2021

bors r+

bors bot pushed a commit that referenced this pull request Apr 19, 2021
…ion (#1954)

Just to avoid confusion to close readers of the example, this fix ensures cake is transformed to the height at the cake's cell, rather than the height at the player's cell.

Without this, cake may be floating or buried, depending on where the player is standing at time of spawning.

Love your work!
@bors bors bot changed the title Fix alien_cake_addict: cake should not be at height of player's location [Merged by Bors] - Fix alien_cake_addict: cake should not be at height of player's location Apr 19, 2021
@bors bors bot closed this Apr 19, 2021
@DJMcNab
Copy link
Member

DJMcNab commented Jul 16, 2021

@alilee please respond in #2373 for the relicense to MIT/Apache 2.0. Thanks!

ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
…ion (bevyengine#1954)

Just to avoid confusion to close readers of the example, this fix ensures cake is transformed to the height at the cake's cell, rather than the height at the player's cell.

Without this, cake may be floating or buried, depending on where the player is standing at time of spawning.

Love your work!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants