[Merged by Bors] - Separate Query filter access from fetch access during initial evaluation #1977
Conversation
cart
added
C-Bug
| #[test] | ||
| fn query_filters_dont_collide_with_fetches() { | ||
| let mut world = World::new(); | ||
| world.query_filtered::<&mut i32, Changed<i32>>(); |
There was a problem hiding this comment.
Should we also add an Added variant here too to spot unusual regressions?
There was a problem hiding this comment.
On the one hand, yes that helps spot unusual regressions. On the other hand, what makes Added more special than With, Without, WithBundle, Or, etc?
Imo we don't need this test to ensure all filter access is implemented correctly (we have other tests for that). We just need to ensure that the filter access doesnt conflict with fetch access (which the test already does).
I think it makes sense to make tests like this small, easy to read, and scoped. So my vote is to leave it as-is (but I concede that there are arguments on both sides).
|
bors r+ |
…ion (#1977) Fixes #1955 See this comment for implementation details / motivation: #1955 (comment)
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
…ion (bevyengine#1977) Fixes bevyengine#1955 See this comment for implementation details / motivation: bevyengine#1955 (comment)
Fixes #1955
See this comment for implementation details / motivation: #1955 (comment)