Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix dead intra links in doc on Input and Reflect #2007

Closed
wants to merge 2 commits into from

Conversation

mockersf
Copy link
Member

fix a few dead links

  • Links in Input missed a refactor
  • Reflect::downcast can't use the intra doc link format, as it's not a link to a trait function, but to a function implemented on dyn Reflect

noticed in #1781 (comment)

crates/bevy_input/src/input.rs Outdated Show resolved Hide resolved
Co-authored-by: MinerSebas <66798382+MinerSebas@users.noreply.github.com>
@Moxinilian Moxinilian added C-Bug An unexpected or incorrect behavior C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Apr 25, 2021
@cart
Copy link
Member

cart commented Apr 25, 2021

bors r+

bors bot pushed a commit that referenced this pull request Apr 25, 2021
fix a few dead links

* Links in `Input` missed a refactor
* `Reflect::downcast` can't use the intra doc link format, as it's not a link to a trait function, but to a function implemented on `dyn Reflect`

noticed in #1781 (comment)
@bors bors bot changed the title fix dead intra links in doc on Input and Reflect [Merged by Bors] - fix dead intra links in doc on Input and Reflect Apr 25, 2021
@bors bors bot closed this Apr 25, 2021
ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
fix a few dead links

* Links in `Input` missed a refactor
* `Reflect::downcast` can't use the intra doc link format, as it's not a link to a trait function, but to a function implemented on `dyn Reflect`

noticed in bevyengine#1781 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Bug An unexpected or incorrect behavior C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants