[Merged by Bors] - Implement direct mutable dereferencing #2100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we should likely not call this method |
alice-i-cecile
added
A-ECS
|
Seems reasonable to me! Maybe a bit counterintuitive to use in practice / users hitting this error will likely find it hard to resolve, but this seems like a fundamental limitation of smart pointers? |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 5, 2021
This PR adds a way to get the underlying mutable reference for it's full lifetime. Context: https://discord.com/channels/691052431525675048/692572690833473578/839255317287796796
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
This PR adds a way to get the underlying mutable reference for it's full lifetime. Context: https://discord.com/channels/691052431525675048/692572690833473578/839255317287796796
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a way to get the underlying mutable reference for it's full lifetime.
Context:
https://discord.com/channels/691052431525675048/692572690833473578/839255317287796796