[Merged by Bors] - Despawn with children doesn't need to remove entities from parents children when parents are also removed #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ildren when parents are also removed
NathanSWard
added
A-Core
NathanSWard
approved these changes
May 29, 2021
|
Is there even a way to detect a changed component of a removed entity? |
Currently no, although that might change in the future. We can revisit later if we implement "removed component change detection" and it becomes an issue. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 30, 2021
…ildren when parents are also removed (#2278) Fixes #2274 When calling `despawn_recursive`, the recursive loop doesn't need to remove the entity from the children list of its parent when the parent will also be deleted Upside: * Removes two entity lookup per entity being recursively despawned Downside: * The change detection on the `Children` component of a deleted entity in the despawned hierarchy will not be triggered
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
…ildren when parents are also removed (bevyengine#2278) Fixes bevyengine#2274 When calling `despawn_recursive`, the recursive loop doesn't need to remove the entity from the children list of its parent when the parent will also be deleted Upside: * Removes two entity lookup per entity being recursively despawned Downside: * The change detection on the `Children` component of a deleted entity in the despawned hierarchy will not be triggered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2274
When calling
despawn_recursive, the recursive loop doesn't need to remove the entity from the children list of its parent when the parent will also be deletedUpside:
Downside:
Childrencomponent of a deleted entity in the despawned hierarchy will not be triggered