Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix unsetting RenderLayers bit in without fn #2409

Closed
wants to merge 1 commit into from

Conversation

andoco
Copy link
Contributor

@andoco andoco commented Jun 28, 2021

Objective

Fixes how the layer bit is unset in the RenderLayers bit mask when calling the without method.

Solution

Unsets the layer bit using &= and the inverse of the layer bit mask.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Jun 28, 2021
@mockersf
Copy link
Member

Thank you for this PR!

You should now that bevy_render is undergoing a large refactor. Even though the part you changed is not touched by it, it may be some time before this PR is merged.

Is it something critical for you?

@mockersf mockersf added A-Rendering Drawing game state to the screen and removed S-Needs-Triage This issue needs to be labelled labels Jun 28, 2021
@andoco
Copy link
Contributor Author

andoco commented Jun 29, 2021

Hi. No it's not critical. I have a workaround by just inserting a new RenderLayers component with the new mask. So no problem waiting.

Thanks!

@cart
Copy link
Member

cart commented Jul 1, 2021

I think theres a good chance that we will use this RenderLayers impl in the new renderer. I'm sold on merging this now / this looks good to me.

@cart
Copy link
Member

cart commented Jul 1, 2021

bors r+

bors bot pushed a commit that referenced this pull request Jul 1, 2021
# Objective

Fixes how the layer bit is unset in the RenderLayers bit mask when calling the `without` method.

## Solution

Unsets the layer bit using `&=` and the inverse of the layer bit mask.
@bors bors bot changed the title Fix unsetting RenderLayers bit in without fn [Merged by Bors] - Fix unsetting RenderLayers bit in without fn Jul 1, 2021
@bors bors bot closed this Jul 1, 2021
@DJMcNab
Copy link
Member

DJMcNab commented Jul 16, 2021

@andoco please respond in #2373 for the relicense to MIT/Apache 2.0. Thanks!

ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
# Objective

Fixes how the layer bit is unset in the RenderLayers bit mask when calling the `without` method.

## Solution

Unsets the layer bit using `&=` and the inverse of the layer bit mask.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants