Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CullMode to none for sprites #241

Merged
merged 1 commit into from
Aug 22, 2020
Merged

Change CullMode to none for sprites #241

merged 1 commit into from
Aug 22, 2020

Conversation

kaflu
Copy link
Contributor

@kaflu kaflu commented Aug 19, 2020

With CullMode::Back, a sprite image that is rotated in x,y plane won't display properly

With `CullMode::Back`, a sprite image that is rotated in x,y plane won't display properly
@karroffel karroffel added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Aug 19, 2020
Copy link
Contributor

@StarArawn StarArawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this makes sense. I think instead making this optional seems like a better idea, but that would likely require significant changes. There are instances where you'd want to cull back faces to increase the speed of sprite rendering.

@StarArawn
Copy link
Contributor

I opened a PR to address sprite flipping here:
#248
However I think we should still allow disabling of culling, but it should be optional.

@cart
Copy link
Member

cart commented Aug 19, 2020

There are instances where you'd want to cull back faces to increase the speed of sprite rendering

Ooh i wasn't aware of this case. What instances?

@StarArawn
Copy link
Contributor

Thinking about how culling works more I don't think it will speed up sprite rendering at all. 😳 There may be some cases where you only want sprites to render from one side though so I still think it should be optional. I think its fine if we disable the culling by default though.

@cart
Copy link
Member

cart commented Aug 22, 2020

Cool I think this is good to go. Thanks!

@cart cart merged commit 2dadc86 into bevyengine:master Aug 22, 2020
BimDav pushed a commit to BimDav/bevy that referenced this pull request Aug 26, 2020
With `CullMode::Back`, a sprite image that is rotated in x,y plane won't display properly

Co-authored-by: kaflu <kaflu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants