-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - wgpu has been moved from "wgpu-rs" to "wgpu" #2445
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
approved these changes
Jul 9, 2021
NiklasEi
approved these changes
Jul 9, 2021
@mockersf can you trigger the workflow? I don't think I can. |
bors r+ |
@NiklasEi no one but Cart can trigger the workflow directly, but you should be able to run |
Pull request successfully merged into main. Build succeeded: |
@temhotaokeaha please respond in #2373 for the relicense to MIT/Apache 2.0. Thanks! |
bors bot
pushed a commit
that referenced
this pull request
Jul 17, 2021
# Objective Currently we can sometimes allow PRs by people who haven't agreed to the relicense to get merged into main. E.g. #2445 ## Solution This adds a check to ensure that this doesn't happen, by ensuring that bors doesn't relicense said PRs. As a bonus, it also adds config to automatically label new PRs as needing checking, to ensure that we do the verification until we merge the new license.
DJMcNab
added a commit
to DJMcNab/bevy
that referenced
this pull request
Jul 17, 2021
This makes more sense when we are talking about the wgpu project as a whole Obsoletes bevyengine#2445
bors bot
pushed a commit
that referenced
this pull request
Jul 17, 2021
This obsoletes #1111 and #2445, since @ColonisationCaptain and @temhotaokeaha haven't replied to #2373. I believe that both of those PRs would be fine to keep, but they're even more fine to keep now :)
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
Name and link update
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
# Objective Currently we can sometimes allow PRs by people who haven't agreed to the relicense to get merged into main. E.g. bevyengine#2445 ## Solution This adds a check to ensure that this doesn't happen, by ensuring that bors doesn't relicense said PRs. As a bonus, it also adds config to automatically label new PRs as needing checking, to ensure that we do the verification until we merge the new license.
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
This obsoletes bevyengine#1111 and bevyengine#2445, since @ColonisationCaptain and @temhotaokeaha haven't replied to bevyengine#2373. I believe that both of those PRs would be fine to keep, but they're even more fine to keep now :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-Docs
An addition or correction to our documentation
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and link update