Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Re-implement Automatic Sprite Sizing #2613

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Re-implement Automatic Sprite Sizing #2613

wants to merge 1 commit into from

Conversation

zicklag
Copy link
Member

@zicklag zicklag commented Aug 6, 2021

Objective

  • Prevent the need to specify a sprite size when using the pipelined sprite renderer

Solution

  • Re-introduce the sprite auto resize system from the old renderer

cart
cart reviewed Aug 10, 2021
View reviewed changes
pipelined/bevy_sprite2/src/sprite.rs
@@ -37,3 +40,26 @@ impl Sprite {
}
}
}

/// System that resizes sprites that have their resize mode set to automatic
pub fn sprite_auto_resize_system(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for now (and i know this is the approach we currently use), but its worth calling out that we can probably do better than polling every texture for every sprite every frame. But I'm fine eating the perf cost (~0.9 milliseconds per frame for 67,000 sprites in bevymark_pipelined or ~3 fps).

@cart
Copy link
Member

cart commented Aug 10, 2021

bors r+

bors bot pushed a commit that referenced this pull request Aug 10, 2021
@zicklag
Re-implement Automatic Sprite Sizing (#2613)
c833003 
# Objective

- Prevent the need to specify a sprite size when using the pipelined sprite renderer

## Solution

- Re-introduce the sprite auto resize system from the old renderer
@bors
Copy link
Contributor

bors bot commented Aug 10, 2021

Pull request successfully merged into pipelined-rendering.

Build succeeded:

@bors bors bot changed the title Re-implement Automatic Sprite Sizing [Merged by Bors] - Re-implement Automatic Sprite Sizing Aug 10, 2021
@bors bors bot closed this Aug 10, 2021
@zicklag zicklag deleted the pipelined-sprite-auto-sizing branch August 10, 2021 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cart cart cart left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zicklag @cart