Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for binary glTF (.glb) #271

Merged
merged 2 commits into from
Aug 25, 2020
Merged

Add support for binary glTF (.glb) #271

merged 2 commits into from
Aug 25, 2020

Conversation

eliaspekkala
Copy link
Contributor

This pull request adds support for the third variant of the glTF file format: glTF Binary (.glb).

@karroffel karroffel added A-Assets Load files from disk to use for things like images, models, and sounds C-Enhancement A new feature labels Aug 21, 2020
@cart
Copy link
Member

cart commented Aug 22, 2020

I like it. I think it would be nice to expand the load_model example to also load a .glb file. This would both illustrate how its done and give us a way to validate that the feature works (both now and in the future).

@cart
Copy link
Member

cart commented Aug 25, 2020

Looks good! cargo fmt isnt your fault. We really need to add bors 😄

@cart cart merged commit 9aff0bc into bevyengine:master Aug 25, 2020
@eliaspekkala eliaspekkala deleted the binary-gltf branch August 26, 2020 08:44
BimDav pushed a commit to BimDav/bevy that referenced this pull request Aug 26, 2020
Add support for binary glTF (.glb)
mrk-its pushed a commit to mrk-its/bevy that referenced this pull request Oct 6, 2020
Add support for binary glTF (.glb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Enhancement A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants