Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Implement IntoSystemDescriptor for SystemDescriptor #2718

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Implement IntoSystemDescriptor for SystemDescriptor #2718

wants to merge 1 commit into from

Conversation

GarettCooper
Copy link
Contributor

Objective

Solution

  • Implements the the IntoSystemDescriptor trait for SystemDescriptor, which simply returns itself

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Aug 24, 2021
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible and removed S-Needs-Triage This issue needs to be labelled labels Aug 24, 2021
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Aug 24, 2021
@cart
Copy link
Member

cart commented Aug 24, 2021

bors r+

bors bot pushed a commit that referenced this pull request Aug 24, 2021
@GarettCooper
Implement IntoSystemDescriptor for SystemDescriptor (#2718)
47ccebf 
# Objective

- Fixes  #2716

## Solution

- Implements the the IntoSystemDescriptor trait for SystemDescriptor, which simply returns itself
@bors
Copy link
Contributor

bors bot commented Aug 24, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Implement IntoSystemDescriptor for SystemDescriptor [Merged by Bors] - Implement IntoSystemDescriptor for SystemDescriptor Aug 24, 2021
@bors bors bot closed this Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@Ratysz Ratysz Ratysz approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SystemDescriptor does not implement IntoSystemDescriptor
4 participants
@GarettCooper @cart @Ratysz @alice-i-cecile