[Merged by Bors] - Add builder methods to Transform #2778
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afonsolage
approved these changes
Sep 6, 2021
Nilirad
approved these changes
Sep 6, 2021
cart
reviewed
Sep 6, 2021
| @@ -105,6 +105,27 @@ impl GlobalTransform { | |||
| self | |||
| } | |||
|
|
|||
| #[doc(hidden)] | |||
There was a problem hiding this comment.
I added it because the other creation methods (looking_at and from_*) are all doc(hidden).
I think it's a bit strange that they are hidden but users don't usually create GlobalTransforms.
There was a problem hiding this comment.
hmm yeah then i guess we can just leave this as-is for now and then circle back if/when we need to with docs.
NiklasEi
added
C-Usability
IceSentry
approved these changes
Sep 7, 2021
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 9, 2021
# Objective
Make it easier to construct transforms. E.g.
```rs
Transform::from_xyz(0.0, 0.0, 10.0).with_scale(Vec3::splat(2.0))
```
I found myself writing an extension method to do this so I don't have to write:
```rs
Transform {
translation: Vec3::new(0.0, 0.0, 10.0),
scale: Vec3::splat(2.0),
..Default::default()
}
```
## Solution
Add *builder style* methods to `Transform`.
Methods:
- `with_translation`
- `with_rotation`
- `with_scale`
I also added these methods to `GlobalTransform`. But they are probably less useful there.
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Make it easier to construct transforms. E.g.
I found myself writing an extension method to do this so I don't have to write:
Solution
Add builder style methods to
Transform.Methods:
with_translationwith_rotationwith_scaleI also added these methods to
GlobalTransform. But they are probably less useful there.