[Merged by Bors] - Fix window size change panic #2858
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 tasks
|
Long-term this should probably be implemented using the window creation / resizing / etc events but that was a rabbit hole I didn't want to go down for now. |
alice-i-cecile
added
A-Rendering
|
Tested on linux/vulkan, works as expected 👍 |
|
One thing I didn't test yet but accidentally did earlier was moving a window between screens that are using different scale factors. I think it should work but I need to test. |
It works too. :) |
|
Just tested on Windows and Linux. Looks good to me! |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 23, 2021
# Objective Using fullscreen or trying to resize a window caused a panic. Fix that. ## Solution - Don't wholesale overwrite the ExtractedWindows resource when extracting windows - This could cause an accumulation of unused windows that are holding onto swap chain frames? - Check the if width and/or height changed since the last frame - If the size changed, recreate the swap chain - Ensure dimensions are >= 1 to avoid panics due to any dimension being 0
|
Pull request successfully merged into pipelined-rendering. Build succeeded: |
bors
bot
changed the title
bors bot
pushed a commit
that referenced
this pull request
Oct 15, 2021
The fix originally got introduced in [#2858](https://github.com/bevyengine/bevy/pull/2858/files#diff-0f34eeda7ac2fe1f9e9b27de92d9290e0b360ffa6f032770aff22b5fef4eaa63R137-R143) but got lost in the upgrade to wgpu 0.11 at #2933
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Using fullscreen or trying to resize a window caused a panic. Fix that.
Solution