Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - increase light intensity in pbr_pipelined example #3182

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - increase light intensity in pbr_pipelined example #3182

wants to merge 2 commits into from

Conversation

mockersf
Copy link
Member

Objective

  • example pbr_pipelined doesn't look like example pbr

pbr:
pbr

pbr_pipelined:
pbr_pipelined

Solution

  • set the light intensity to a higher value

pbr_pipelined with this pr:
pbr_pipelined_fixed

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Nov 25, 2021
@mockersf mockersf added A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples and removed S-Needs-Triage This issue needs to be labelled labels Nov 25, 2021
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 25, 2021
@superdump
Copy link
Contributor

Hmm. I suspect this is due to me changing the way intensity was handled when I spotted a small error in the maths that was meant to convert from inout units to the units needed in the shader. I think the difference was a factor of 4 pi.

@MinerSebas MinerSebas mentioned this pull request Nov 26, 2021
Closed
@mockersf
Copy link
Member Author

changed the value to have a factor of 12, closer to 4*pi

@mockersf
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Nov 27, 2021
@mockersf
increase light intensity in pbr_pipelined example (#3182)
7ced541 
# Objective

- example `pbr_pipelined` doesn't look like example `pbr`

`pbr`:
![pbr](https://user-images.githubusercontent.com/8672791/143328022-83797197-233c-4824-8daa-4d7bd092938d.png)


`pbr_pipelined`:
![pbr_pipelined](https://user-images.githubusercontent.com/8672791/143328034-8a8bdb39-0d75-472b-8880-7bb7cd48f448.png)


## Solution

- set the light intensity to a higher value

`pbr_pipelined` with this pr:
![pbr_pipelined_fixed](https://user-images.githubusercontent.com/8672791/143328040-4149e96c-dada-4940-9f6f-f8925e48b22e.png)
@bors
Copy link
Contributor

bors bot commented Nov 27, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title increase light intensity in pbr_pipelined example [Merged by Bors] - increase light intensity in pbr_pipelined example Nov 27, 2021
@bors bors bot closed this Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@superdump superdump superdump approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mockersf @superdump @alice-i-cecile