Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix: as_rgba_linear used wrong variant #3192

Closed
wants to merge 1 commit into from

Conversation

molikto
Copy link
Contributor

@molikto molikto commented Nov 26, 2021

Objective

as_rgba_linear used wrong variant

Solution

Fixed it.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Nov 26, 2021
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Triage This issue needs to be labelled labels Nov 26, 2021
@mockersf
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Nov 26, 2021
# Objective

as_rgba_linear used wrong variant

## Solution

Fixed it.
@bors bors bot changed the title fix: as_rgba_linear used wrong variant [Merged by Bors] - fix: as_rgba_linear used wrong variant Nov 26, 2021
@bors bors bot closed this Nov 26, 2021
HackerFoo pushed a commit to HackerFoo/bevy that referenced this pull request Nov 26, 2021
# Objective

as_rgba_linear used wrong variant

## Solution

Fixed it.
bors bot pushed a commit that referenced this pull request Nov 28, 2021
# Objective

- After #3192, some places where `as_rgba_linear` was called were doing too many conversions

## Solution

- Fix the conversions
@molikto molikto deleted the fix-color branch April 17, 2022 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants