Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Improve contributors example quality #3258

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - Improve contributors example quality #3258

wants to merge 8 commits into from

Commits on Dec 5, 2021

  1. Renamed unclear variable names

    @CrazyRoka
    CrazyRoka committed Dec 5, 2021
    Configuration menu
    Copy the full SHA
    7ef90ed View commit details
    Browse the repository at this point in the history

  2. Splitted setup system into two separate systems

    @CrazyRoka
    CrazyRoka committed Dec 5, 2021
    Configuration menu
    Copy the full SHA
    adad7c3 View commit details
    Browse the repository at this point in the history

  3. Added error handling and default values

    @CrazyRoka
    CrazyRoka committed Dec 5, 2021
    Configuration menu
    Copy the full SHA
    6ec10a0 View commit details
    Browse the repository at this point in the history

  4. Renamed error enumeration and fixed ci

    @CrazyRoka
    CrazyRoka committed Dec 5, 2021
    Configuration menu
    Copy the full SHA
    11abd5a View commit details
    Browse the repository at this point in the history

  5. Reduced contributors array and added docs

    @CrazyRoka
    CrazyRoka committed Dec 5, 2021
    Configuration menu
    Copy the full SHA
    44e0ac6 View commit details
    Browse the repository at this point in the history

  6. Update comment in contributors example 

    Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
    @CrazyRoka @alice-i-cecile
    CrazyRoka and alice-i-cecile authored Dec 5, 2021
    Configuration menu
    Copy the full SHA
    7155eac View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2021

  1. Replaced BTreeSet with HashSet

    @CrazyRoka
    CrazyRoka committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    db3c4bf View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2021

  1. Moved LoadContributorsError closer to the function

    @CrazyRoka
    CrazyRoka committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    6ccbc30 View commit details
    Browse the repository at this point in the history