Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Rename fixed timestep state and add a test #3260

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - Rename fixed timestep state and add a test #3260

wants to merge 6 commits into from

Conversation

NiklasEi
Copy link
Member

@NiklasEi NiklasEi commented Dec 5, 2021 •
edited
Loading

Objective

fixes #3234

Solution

  • rename bevy::core::State to LocalFixedTimestepState
  • add a test for FixedTimestep since I am already there

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Dec 5, 2021
@NiklasEi NiklasEi added A-Core Common functionality for all bevy apps C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Needs-Review and removed S-Needs-Triage This issue needs to be labelled labels Dec 5, 2021
@NiklasEi @alice-i-cecile
Update crates/bevy_core/src/time/fixed_timestep.rs
3e4d705 
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 5, 2021
DJMcNab
DJMcNab approved these changes Dec 11, 2021
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked the test code, but the renaming looks good.

I want this to land, because I want to refactor FixedTimestep.

@cart
Copy link
Member

cart commented Dec 12, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 12, 2021
@NiklasEi
Rename fixed timestep state and add a test (#3260)
de8edd3 
# Objective

fixes #3234

## Solution

- rename `bevy::core::State` to `LocalFixedTimestepState`
- add a test for FixedTimestep since I am already there
@bors
Copy link
Contributor

bors bot commented Dec 12, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Rename fixed timestep state and add a test [Merged by Bors] - Rename fixed timestep state and add a test Dec 12, 2021
@bors bors bot closed this Dec 12, 2021
@NiklasEi NiklasEi deleted the fixed_timestep_rename branch December 12, 2021 22:09
@mockersf mockersf mentioned this pull request Jan 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@DJMcNab DJMcNab DJMcNab approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Core Common functionality for all bevy apps C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename bevy::core::State
5 participants
@NiklasEi @cart @alice-i-cecile @mockersf @DJMcNab