Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix hierarchy example panic #3378

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Fix hierarchy example panic #3378

wants to merge 1 commit into from

Conversation

cryscan
Copy link
Contributor

@cryscan cryscan commented Dec 19, 2021

Objective

Fixes #3321

Solution

Uses despawn_recursive() instead of despawn() when removing children.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Dec 19, 2021
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples and removed S-Needs-Triage This issue needs to be labelled labels Dec 19, 2021
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it P-Crash A sudden unexpected crash labels Dec 19, 2021
@cart
Copy link
Member

cart commented Dec 20, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 20, 2021
# Objective
Fixes #3321 

## Solution
Uses `despawn_recursive()` instead of `despawn()` when removing children.
@bors bors bot changed the title Fix hierarchy example panic [Merged by Bors] - Fix hierarchy example panic Dec 20, 2021
@bors bors bot closed this Dec 20, 2021
mockersf pushed a commit to mockersf/bevy that referenced this pull request Dec 21, 2021
# Objective
Fixes bevyengine#3321 

## Solution
Uses `despawn_recursive()` instead of `despawn()` when removing children.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples P-Crash A sudden unexpected crash S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hierarchy example panics after a second or two
3 participants