[Merged by Bors] - Add some of the missing methods to TrackedRenderPass
#3401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-Rendering
|
Thanks for tackling this; I saw your comment in #1369 and was about to attempt this myself in some form or another :) |
|
We probably need to eventually add state for |
|
Looks good to me! |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 20, 2021
# Objective Add missing methods to `TrackedRenderPass` - `set_push_constants` - `set_viewport` - `insert_debug_marker` - `push_debug_group` - `pop_debug_group` - `set_blend_constant` https://docs.rs/wgpu/0.12.0/wgpu/struct.RenderPass.html I need `set_push_constants` but started adding the others as I noticed they were also missing. The `draw indirect` family of methods are still missing as are the `timestamp query` methods.
bors
bot
changed the title
TrackedRenderPassTrackedRenderPass
mockersf
pushed a commit
to mockersf/bevy
that referenced
this pull request
Dec 21, 2021
# Objective Add missing methods to `TrackedRenderPass` - `set_push_constants` - `set_viewport` - `insert_debug_marker` - `push_debug_group` - `pop_debug_group` - `set_blend_constant` https://docs.rs/wgpu/0.12.0/wgpu/struct.RenderPass.html I need `set_push_constants` but started adding the others as I noticed they were also missing. The `draw indirect` family of methods are still missing as are the `timestamp query` methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Add missing methods to
TrackedRenderPassset_push_constantsset_viewportinsert_debug_markerpush_debug_grouppop_debug_groupset_blend_constanthttps://docs.rs/wgpu/0.12.0/wgpu/struct.RenderPass.html
I need
set_push_constantsbut started adding the others as I noticed they were also missing. Thedraw indirectfamily of methods are still missing as are thetimestamp querymethods.