[Merged by Bors] - enable wasm-bindgen feature on gilrs
#3420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should this feature only be enabled when target is wasm? |
No, |
jakobhellermann
added
A-Input
mockersf
approved these changes
Dec 23, 2021
Ixentus
approved these changes
Dec 23, 2021
There was a problem hiding this comment.
Note that although it builds with wasm, it usually can't find controllers (although it works when it does). See https://gitlab.com/gilrs-project/gilrs/-/issues/107
The PR looks good though
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 23, 2021
WIthout the feature, `gilrs` uses `stdweb` instead of `wasm-bindgen` which isn't compatible with the rest of bevy. Unfortunately, the `stdweb` dependency is still in the dependency tree, it just isn't used (https://gitlab.com/gilrs-project/gilrs/-/issues/101). This will be fixed in `gilrs 0.9` when it releases.
bors
bot
changed the title
wasm-bindgen feature on gilrswasm-bindgen feature on gilrs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIthout the feature,
gilrsusesstdwebinstead ofwasm-bindgenwhich isn't compatible with the rest of bevy.Unfortunately, the
stdwebdependency is still in the dependency tree, it just isn't used (https://gitlab.com/gilrs-project/gilrs/-/issues/101). This will be fixed ingilrs 0.9when it releases.