Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - crevice derive macro: fix path to render_resource when importing from bevy #3438

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - crevice derive macro: fix path to render_resource when importing from bevy #3438

wants to merge 1 commit into from

Conversation

mockersf
Copy link
Member

Objective

Solution

  • Do not add twice render_resource when coming from bevy

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Dec 25, 2021
@mockersf mockersf added A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior and removed S-Needs-Triage This issue needs to be labelled labels Dec 25, 2021
@mockersf mockersf changed the title fix path to render_resource when importing from bevy crevice derive macro: fix path to render_resource when importing from bevy Dec 25, 2021
@DJMcNab DJMcNab added the P-High This is particularly urgent, and deserves immediate attention label Dec 25, 2021
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 25, 2021
@cart
Copy link
Member

cart commented Dec 26, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 26, 2021
@mockersf
crevice derive macro: fix path to render_resource when importing from…
f3b053d 
… bevy (#3438)

# Objective

- Fix #3436 

## Solution

- Do not add twice `render_resource` when coming from `bevy`


Co-authored-by: François <8672791+mockersf@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Dec 26, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title crevice derive macro: fix path to render_resource when importing from bevy [Merged by Bors] - crevice derive macro: fix path to render_resource when importing from bevy Dec 26, 2021
@bors bors bot closed this Dec 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@DJMcNab DJMcNab DJMcNab approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior P-High This is particularly urgent, and deserves immediate attention S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bevy_crevice derive macro doesn't work properly in external crate
4 participants
@mockersf @cart @alice-i-cecile @DJMcNab